perf: don't eval attr just pass to isinstance #164
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cls._meta._get_fields(reverse=True, forward=False) would be a better option, I've swtiched to using class_method to avoid this issue, but this was a nasty surprise. :( a warning about using class_property in the docs would be good. |
| attr = getattr(cls, name, None) | ||
|
|
||
| if attr and isinstance(attr, DJANGO_RELATED_FIELD_DESCRIPTOR_CLASSES): | ||
| if isinstance(attr, DJANGO_RELATED_FIELD_DESCRIPTOR_CLASSES): |
There was a problem hiding this comment.
Does this avoid property evaluation? I'm not sure about it.
Could you make a test to prove it? If not I could help with that.
(sorry about answering so late)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a nasty issue where I had a large QS be a @class_property, and this code caused it to eval the QS, there's no need to eval it, just pass it directly do isinstance, if we really want a check, a
is not Nonewould be better.But would be even better if this didn't loop over all properities, rather it used
cls._meta.related_objects